feat: delete model #134
feat: delete model #134
Conversation
feloy
force-pushed
the
feat-50/manage-models-2
branch
8 times, most recently
from
8e3d2ce to
408a6d8
Compare
| this.#deleted.add(modelId); | ||
| await this.sendModelsInfo(); | ||
| try { | ||
| await fs.promises.rm(modelDir, { recursive: true }); |
There was a problem hiding this comment.
The recursive option for deleting always scares me, something we could do, is listing all the files inside the model directory, ask user for confirmation something like
"The following files will be deleted
- model-a.gguff
"
Then delete them by name instead of deleting the folder ? (I am maybe just overreacting)
|
|
||
| <ListItemButtonIcon | ||
| icon={faTrash} | ||
| onClick={() => deleteModel()} |
There was a problem hiding this comment.
Yeah we need confirmation modal
feloy
force-pushed
the
feat-50/manage-models-2
branch
from
ce3c39c to
425ef27
Compare
On Windows, right? I'll have a look |
Yes |
|
@feloy maybe i got what happened. I had my playground running and i tried to delete the model 🤔 I'll try again, but we should inform the user in this case. UPDATE: I confirm. It works fine when the model is not used. |
Yes, I would like to display the error message to the user in this case, but for now, AI Studio doesn't have a clear way to display errors coming from the backend (as the call is async, we cannot get the error as the result from a call to a @jeffmaury what do you think? Do we want to implement a generic error handler (kind of notifications), something else? |
I saw Axel just pushed #152 . Maybe adding a task to the taksmanager and an error icon next to the delete icon that opens up the task manager? |
feloy
force-pushed
the
feat-50/manage-models-2
branch
4 times, most recently
from
91d14a9 to
72db6d8
Compare
feloy
force-pushed
the
feat-50/manage-models-2
branch
from
72db6d8 to
9861dc9
Compare
feloy
force-pushed
the
feat-50/manage-models-2
branch
from
9861dc9 to
1aa5701
Compare
fixes partially #50